Repository navigation
[Bug][Fix] Handle concatenation of 1D empty tensors with higher-dimensional tensors - #20762
Open
Netra-Srinivasan-McW wants to merge 2 commits into
Open
Netra-Srinivasan-McW wants to merge 2 commits into
Netra-Srinivasan-McW wants to merge 2 commits into
Conversation
Author
Netra-Srinivasan-McW
force-pushed
the
concat-empty-tensor-fix
branch
from
October 23, 2026 16:45
bb84ece to
8e3d8b2
Compare
Author
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Filtering empty inputs produces incorrect dtype promotion, while the singleton shortcut bypasses rank and axis validation, allowing invalid concatenations to succeed.
2 open issues
What changed in this PR
Updates Relax’s PyTorch frontend to handle concatenation of empty 1D tensors with higher-rank tensors, addressing initially empty model caches described in #20761.
Changes:
- Filters known
(0,)inputs and returns the remaining tensor directly when only one remains. - Preserves the original input list when all tensors are empty.
- Adds regression tests for both frontend import paths.
| File | Description |
|---|---|
tests/python/relax/test_frontend_from_fx.py |
Adds an empty-tensor concatenation regression for FX import. |
tests/python/relax/test_frontend_from_exported_program.py |
Adds the corresponding exported-program regression. |
python/tvm/relax/frontend/torch/base_fx_graph_translator.py |
Implements empty-input filtering and the single-tensor shortcut. |
Review effort: Max
Netra-Srinivasan-McW
force-pushed
the
concat-empty-tensor-fix
branch
from
November 17, 2026 17:46
8e3d8b2 to
395fb8c
Compare
Author
|
Hi @mshr-h, @yzhliu, @tqchen, @tlopex, I have updated the PR to address all the review changes:
Could you please take a look into the changes when you get a chance? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue
PyTorch supports concatenating a 1D empty tensor (shape
(0,)) with a higher-dimensional tensor. On the other hand, TVM Relax raises an error when the input tensors have different numbers of dimensions.This issue occurs in models such as Perplexity AI's pplx-embed-v2-late-9b, where the KV cache is initially represented as a 1D empty tensor. Concatenating it with higher-dimensional key/value tensors causes the Relax frontend conversion to fail.
Solution
This PR updates the Relax frontend to handle concatenation of a 1D empty tensor with a higher-dimensional tensor, enabling model execution to proceed without this error.
Closes #20761.